Skip to content

Fix Sites fallback file placeholder - #3144

Merged
HarshMN2345 merged 1 commit into
mainfrom
codex/fix-sites-fallback-placeholder
Jul 31, 2026
Merged

Fix Sites fallback file placeholder#3144
HarshMN2345 merged 1 commit into
mainfrom
codex/fix-sites-fallback-placeholder

Conversation

@HarshMN2345

Copy link
Copy Markdown
Member

Summary

  • keep empty Sites fallback file values empty in build settings
  • leave index.html as placeholder-only unless the user explicitly sets it or changes framework/adapter defaults

Tests

  • bun run check

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR keeps empty Sites fallback-file values empty while retaining framework and adapter defaults for explicit selection changes.

  • Normalizes a missing fallback value to an empty form value.
  • Removes the reactive behavior that replaced empty static fallback values with the adapter default.

Confidence Score: 5/5

The PR appears safe to merge with no actionable changed-code defects identified.

The removed reactive defaulting duplicated the existing explicit framework and adapter transition logic and prevented empty fallback values from remaining empty; the retained transitions still apply defaults when selections change.

Important Files Changed

Filename Overview
src/routes/(console)/project-[region]-[project]/sites/site-[site]/settings/updateBuildSettings.svelte Empty fallback values now remain placeholder-only, while framework and adapter transitions continue to populate their configured defaults.

Reviews (1): Last reviewed commit: "fix sites fallback placeholder" | Re-trigger Greptile

@HarshMN2345
HarshMN2345 merged commit b1ac625 into main Jul 31, 2026
3 of 4 checks passed
@HarshMN2345
HarshMN2345 deleted the codex/fix-sites-fallback-placeholder branch July 31, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants